Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and release #4

Merged
merged 5 commits into from Jul 15, 2020
Merged

Fixes and release #4

merged 5 commits into from Jul 15, 2020

Conversation

JuiP
Copy link
Member

@JuiP JuiP commented Jul 11, 2020

  • The activity process kept running even after clicking on the stop button. Fixed in 2a7e978
  • PyGIWarnings fixed
  • Release new version

@quozl @chimosky please test and review changes till 403e47c. So I can push release related changes

JuiP added 2 commits July 11, 2020 14:30
The activity process keep running even after closing the activity using the stop button on toolbar.
Confirmed using testing the activity from terminal using sugar-activity3
/usr/share/sugar/activities/jam-clock.activity/Main.py:34: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded.
@quozl
Copy link

quozl commented Jul 13, 2020

Re: 403e47c. It is better to move the existing gi.require_version check higher in the source file it occurs in, or import Main later.

@JuiP
Copy link
Member Author

JuiP commented Jul 14, 2020

These activity versions are not uploaded on https://activities.sugarlabs.org/en-US/sugar/search?q=clock&cat=all.
The method of download I mentioned in the README is download from GitHub. Is there any way to upload this activity on https://activities.sugarlabs.org ?

Also, I feel why not include this activity as a part of sugar? Like a similar implememntation of Analyze Journal to dashboard?
@quozl @chimosky @srevinsaju

@quozl
Copy link

quozl commented Jul 14, 2020

Clock is often used instead.

JAMclock was written for a specific country school system. JAMclock was available on activities.laptop.org as node 4508 but has been deleted, possibly by the original maintainer. The repository here was uploaded by someone other than the original maintainer. activities.sugarlabs.org at the moment can't host Python 3 activities because it has no concept of the Python 2 to Python 3 transition, and loading a Python 3 activity to those old laptops in the field will break the activity, with the child usually unable to recover an older version. With the older version missing from activities.sugarlabs.org, it is even more important not to release a Python 3 version there. @srevinsaju has been working on a replacement for activities.sugarlabs.org which may have some way to detect which versions of Python are supported by the toolkit. It is a complicated thing; JavaScript on a web page has to have a way to query the Browse activity to introspect the Sugar Toolkit without executing it.

@quozl
Copy link

quozl commented Jul 14, 2020

Thanks. Reviewed. Approved.

@chimosky
Copy link
Member

Reviewed, thanks.

@chimosky chimosky merged commit 4c32134 into sugarlabs:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants