Fixes #12
Merged
Fixes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Traceback (most recent call last):
File "/usr/share/sugar/activities/jamath.activity/sugargame/canvas.py", line 65, in _run_pygame_cb
main_fn()
File "/usr/share/sugar/activities/jamath.activity/juego.py", line 254, in run
self.play(level)
File "/usr/share/sugar/activities/jamath.activity/juego.py", line 186, in play
fondo = [load_image("data/" + str(x) + ".jpg") for x in range(0,NUM_IMAGES)]
File "/usr/share/sugar/activities/jamath.activity/juego.py", line 261, in load_image
return pygame.image.load(path).convert_alpha()
pygame.error: Couldn't open data/data/0.jpg
Introduced by commit 183ace7
srevinsaju
reviewed
Jul 28, 2020
chimosky
reviewed
Jul 28, 2020
Traceback (most recent call last):
File "/usr/share/sugar/activities/jamath.activity/sugargame/canvas.py", line 65, in _run_pygame_cb
main_fn()
File "/usr/share/sugar/activities/jamath.activity/juego.py", line 254, in run
self.play(level)
File "/usr/share/sugar/activities/jamath.activity/juego.py", line 189, in play
puntuacionalta = load_puntuacionalta()
File "/usr/share/sugar/activities/jamath.activity/juego.py", line 289, in load_puntuacionalta
file_path = os.path.join(os.environ['SUGAR_ACTIVITY_ROOT'], 'data', 'PuntajeAlto')
File "/usr/lib/python2.7/UserDict.py", line 40, in __getitem__
raise KeyError(key)
KeyError: 'SUGAR_ACTIVITY_ROOT'
Fix : run should not include pygame.init, stop pygame animation on use of GTK stop button, return on quit, change toolbar definition
Warning, unable to load: data/./data/menu.ogg Warning, unable to load: data/./data/right.ogg Warning, unable to load: data/./data/wrong.ogg
|
Made changes as suggested; @quozl @srevinsaju @chimosky Kindly review and test again :) |
srevinsaju
suggested changes
Aug 9, 2020
activity_root which has the path returned by get_activity_root(), is passed as an argument to the functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The activity was not usable before these changes.
Also Fixes #4
Regarding commit - f9e7aeb : The required change is due to version differences of Libpng. From what I found, Libpng-1.6 is more stringent about checking ICC profiles than previous versions. We can ignore the warning but to get rid of it, we need to remove the iCCP chunk from the PNG image.
@chimosky @quozl @srevinsaju Please test and review :)