tooling: webpack setup, prod/dev typed configs, remove CRA [week 1] - #194
Merged
Merged
Conversation
* add webpack 5, webpack dev server and webpack merge * enabled fully typed webpack configs * dev and prod webpack configs under webpack/ * proper webpack config loaded in correct env * add loaders for scss, png, svg and tsx files * remove craco, react-scripts * remove CRA specific path from index.html Signed-off-by: Anik Das <anikdas0811@gmail.com>
* switch to named exports for webpack configs Signed-off-by: Anik Das <anikdas0811@gmail.com>
* use copy-webpack-plugin to copy from public to build * ignore index.html in public as html-webpack-plugin uses that as template and generates one for us already Signed-off-by: Anik Das <anikdas0811@gmail.com>
* for html-webpack-plugin * for mini-css-extract-plugin * remove redundant output config * document final config function Signed-off-by: Anik Das <anikdas0811@gmail.com>
meganindya
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Points to note:
Current build is hosted at: https://sadn1ck.github.io/musicblocks-v4/