-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mode/Key Pie-Selector #1223
Comments
Foreword: Please let me know what you think. I am trying to balance simplicity of representation with pitch-sets' inherent complexity. The thing is, 1) there are a lot of possible combinations (although finite), 2) many sets of pitches are known by many different names, and 3) it is nice to have an organizational structure for the possible pitch sets. We could have something like the following (note that both pictures are the same thing--one with pencil, the other on a whiteboard): Examples of "Locrian" and "Major" (aka Ionian), which only differs by "transpositional rotation" although they are in the same family for scales with the same cardinality (left of hyphen) and list number (right of hyphen) for "normal form". Note: I chose to come up with "transpositional rotation" ("TR" as I have it in the designs) instead of "transposition" because it simplifies how possibilities are handled (for example, if one chooses the number "3", not all list possibilities have the potential to be "transposed by three semitones", but can be "rotated three times"). The details of where the boxes are and where the graphic representation is, I do not have a particular opinion about. Note that modifying the number in the list number would be redundant to rotating through the list (so perhaps it is not necessarily modifiable...). However, modifying the cardinality has important implications--it changes the entire pie menu list items! Also, changing TR and/or I (Inversion) changes the possible scales in the list. |
Not sure I completely understand, but I will make some sketches we can iterate from. Meanwhile, check this out https://vimeo.com/51072812 and think modes. And this one: https://vimeo.com/51073078 |
This is a sketch of what I am thinking. We can have a wheel for mode length (although we probably want to entries for 7 -- the common modes and all the others). I have not implemented your spacing idea yet in this sketch, but it should be doable. I also have not thought about how to include the extra navigation you propose (which is the same navigation we have in the mode widget). Maybe we don't really need it here. |
@walterbender Please push this branch so that I can check it out.
Yes, I realize that there is some overlap, which I am also struggling with as I suspect that it is avoidable. However, I still think that there is some merit to these other systems of organization, and I am trying to incorporate the best of that system into our system. I will continue to explore the new possibilities we have before us. |
Pushed to master. I'm pretty happy with it in general... much cleaner than the previous implementation. |
What is happening when I click a darkened space? I see the animation and it seems to go to the nearest scale--is that correct? I think it might be nice to have a play button, perhaps next to the close button, so that playback of the entire scale is always convenient. |
I haven't figured out how to disable an individual slice in the pie menu, so for the time being, I advance to the next active slice. I agree, I want to figure out how to put a play icon in the other half of the "exit" pie. In general, is the new organization OK? Is it working OK in Japanese? |
/me Has never given it much thought but wonders if this could have some clever purpose... will think about it.
You did it! It is great! The playback is a little slow for the first few notes, then quickens. I do think that it would be nice to do down the scale as well. Also, in general a quicker playback would be nice. Eighth notes for somehwhere between 110 BPM and 120 I think would be nice.
Yes, the new organization is certainly better, but I know we can do better still. The places I see improvement are basically in the interaction of layers 2 and 3 from what I proposed above. Since common modes is contained in its current design, the problem is not within the common modes part of the selector. However, let's continue this conversation later...
Some of the names extend outside of the wheel. Also, it is funny to read some of them upside down. Perhaps they are always up and have something to help the user identify the name with the corresponding point on the wheel? Or a short name and the full name reveals with tooltip? |
I think the original issue has been resolved. We can discuss taxonomies in other discussions. |
First mentioned #1204 (comment) but mode/key selection implicates complexity beyond what the pie-selectors for other parameters call for.
First proposed change is very, very easy. For pitch selection, when inside of key block (and possibly only when inside of key block), it should be ordered as circle of fifths (C, G, D, A, E, B, F).
...
The text was updated successfully, but these errors were encountered: