-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bigger values overflow from the block #3485
Comments
@walterbender @SamarthBagga can you please tell us what will be the correct implementation for this
Thank you |
prob. we should limit the number of digits to 12? |
Also, how about keeping a min-width of block? so it handles the responsiveness issue too, any thoughts? |
@walterbender, The text block doesn't exhibit this problem. What if we were to apply the text block's style attributes for the number block to resolve the issue? Maybe increasing the width of the number block a bit ? |
Maybe that is a better idea. |
i think text blocks also present this problem @SamarthBagga @walterbender |
@SamarthBagga @walterbender can I please work on this issue?
|
I think this is better solved by limiting the number of digits. |
okay on it :) |
@SamarthBagga @walterbender I've been working on this issue for the past few days, and I've noticed that the current implementation includes a function that calculates the number of pixels written within the block and, as a result, limits the quantity of characters displayed within the block. The current problem is that the exposed pixel limit within the block is too high, but reducing this limit could potentially solve the issue. Can I go ahead and implement this solution? I believe it might be a better approach than limiting the number of characters, considering that each character has a different width |
In most fonts, numbers are a fixed width. In any case, feel free to approach the problem with a character limit. |
in which file is this function written? |
for numbers its 12 but should be the limit for the characters @walterbender sir |
We don't need a limit for characters. |
@walterbender I was testing the changes as you guided, and I noticed that the numbers start being written in the blocks from a point slightly to the left of the center. However, I believe that if they started being written from a point more to the right, it would look aesthetically nicer and, in addition, more digits could fit without having to make major adjustments... What do you think? |
looks good |
@walterbender I changed the TEXTWIDTH to 90 and the block is not over flowing for smaller inputs. But for larger number inputs this is showing. |
We don't want to use ellipsis for numbers. |
I see. Lemme change it. |
Description
If you input larger values in a block for integers, then they tend to overflow from the block.
The text was updated successfully, but these errors were encountered: