Support wider aspect ratios #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quozl
force-pushed
the
2016-229-aspect-ratio
branch
from
c44ea6b
to
9b0689d
Compare
Displays with wider aspect ratios of 16:9 gave squashed thumbnails and photograph views, because the activity assumed a 4:3 aspect ratio. When a photograph was taken, the thumbnail image was shown squashed, people were tall and thin. When a photograph was selected from the tray, the same effect was shown in the media view. The live camera view was also smaller than it could be. Fix is to; - detect the display aspect ratio, and use it for sizing the media view widget, and; - detect the camera aspect ratio, and trim sides of image to fit our 4:3 thumbnail SVG template. Fixes most but not all of https://bugs.sugarlabs.org/ticket/4860
quozl
force-pushed
the
2016-229-aspect-ratio
branch
from
9b0689d
to
8213b88
Compare
|
Rebased against master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays with wider aspect ratios of 16:9 gave squashed thumbnails and photograph views, because the activity assumed a 4:3 aspect ratio.
When a photograph was taken, the thumbnail image was shown squashed, people were tall and thin. When a photograph was selected from the tray, the same effect was shown in the media view. The live camera view was also smaller than it could be.
Fix is to;
Fixes most but not all of https://bugs.sugarlabs.org/ticket/4860
Tested on