Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Fixes #7

merged 4 commits into from
Jun 23, 2020

Conversation

JuiP
Copy link
Member

@JuiP JuiP commented Jun 5, 2020

The activity has been ported to python3 and should be released. Fixing issues before a release.

@srevinsaju @chimosky @quozl please review and test?

- The color of player1 is set to default white.
- Changed the background and board color defaults to contrasting colors so that White moves are easily visible
- Background color is set to dark green by default
- Board color is set to Blue by default
Copy link
Member

@srevinsaju srevinsaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to the choice of green color, as it is the most of the reversi game board is dark green in color.

Is the change and the significance, coincidental, or on purpose?

Great! Tested reviewed.

Copy link
Member

@srevinsaju srevinsaju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I revoke the approval;

On further testing, I have found that the color of the color selector of background color and board color is not reflected in the color chooser. Ideally, the color chooser should show blue and green color unless the user changes it.


Can we change switch the board color and the background color?
As seen in this image
Reversi game

@srevinsaju
Copy link
Member

Ideally, this looks like a good color
image

@JuiP
Copy link
Member Author

JuiP commented Jun 7, 2020

I agree to the choice of green color, as it is the most of the reversi game board is dark green in color.
Is the change and the significance, coincidental, or on purpose?
Great! Tested reviewed. Can we change switch the board color and the background color?

Thanks! @srevinsaju The change was just coincidental. Yes I think switching the board and background color is a better idea. But since the player can choose the color and change it, switching colors shouldn't really make much of a difference, for now it is solving the purpose of having contrasting backgrounds.
@chimosky do you approve these changes?

I have found that the color of the color selector of background color and board color is not reflected in the color chooser. Ideally, the color chooser should show blue and green color unless the user changes it.

Thanks for noticing! I will look into it

activity.py Outdated Show resolved Hide resolved
activity.py Outdated Show resolved Hide resolved
@chimosky
Copy link
Member

Haven't tested, will keep my reviews for when I test.

Looking at the screenshots, it'll be great to have brown as the board's default color as it blends better with black and white than green if you ask me.

@JuiP
Copy link
Member Author

JuiP commented Jun 11, 2020

We cannot have colors close to white and black as backgrounds, it defeats the purpose of having contrasting backgrounds. By contrast I meant contrast to the player colors(which are set to white and black by default). Maybe it will be more clear when you test. :)

@JuiP
Copy link
Member Author

JuiP commented Jun 17, 2020

@quozl @chimosky Can we merge this?

@chimosky
Copy link
Member

Tested, thanks.

I like the new colours.

@chimosky chimosky merged commit 98a6a4d into sugarlabs:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White color has no effect on the Player 1 circles
3 participants