Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to Python 3 #15

Merged
merged 5 commits into from
Jul 10, 2019
Merged

Port to Python 3 #15

merged 5 commits into from
Jul 10, 2019

Conversation

Aniket21mathur
Copy link
Contributor

@Aniket21mathur Aniket21mathur commented Jul 10, 2019 •
edited

Replaces #14
Fixes #7

@Aniket21mathur Aniket21mathur mentioned this pull request Jul 10, 2019
Closed
@Aniket21mathur
Copy link
Contributor Author

Aniket21mathur commented Jul 10, 2019 •
edited by quozl

Tested with:

  • toolkit (HEAD) (build for python2)
  • sugar (HEAD)
  • Write activity and Chat activity.

Observations:

  • Journal gets started.
  • Write activity gets started.
  • Able to export write documents to the journal.
  • Stopping the Write activity stores its instance to the journal.
  • Activity can be resumed from the journal.
  • On collaborating the buddy icon of the friend is shown in the journal.

Thanks!

@quozl quozl merged commit 43aabbc into sugarlabs:master Jul 10, 2019
@quozl
Copy link
Contributor

quozl commented Jul 10, 2019

Thanks. Reviewed.

@Aniket21mathur
Copy link
Contributor Author

@pro-panda @quozl Though I tested it. I request testing it again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port to Python 3
3 participants
@Aniket21mathur @quozl @rhl-bthr