Skip to content

Commit

Permalink
Fix install TypeError
Browse files Browse the repository at this point in the history
Activity install target used by downstream activity packaging did fail
with;

Traceback (most recent call last):
  File "setup.py", line 21, in <module>
    bundlebuilder.start()
  File "/usr/lib/python3.7/dist-packages/sugar3/activity/bundlebuilder.py", line 633, in start
    globals()['cmd_' + options.command](config, options)
  File "/usr/lib/python3.7/dist-packages/sugar3/activity/bundlebuilder.py", line 513, in cmd_install
    options.install_desktop_file)
  File "/usr/lib/python3.7/dist-packages/sugar3/activity/bundlebuilder.py", line 290, in install
    for f in self.get_files_in_git():
  File "/usr/lib/python3.7/dist-packages/sugar3/activity/bundlebuilder.py", line 209, in get_files_in_git
    stdout.strip('\n').split('\n')]
TypeError: a bytes-like object is required, not 'str'

Workaround was to hide .git directory.

Cause was subprocess pipe returning a bytes-like object in Python 3.

Regression introduced by incomplete ed46c21 ("Port to six").

Fixes #426
  • Loading branch information
quozl committed Aug 28, 2019
1 parent 7b85b80 commit 381c9b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/sugar3/activity/bundlebuilder.py
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ def get_files_in_git(self, root=None):
elif stdout:
# pylint: disable=E1103
git_output = [path.strip() for path in
stdout.strip('\n').split('\n')]
stdout.decode().strip('\n').split('\n')]
files = []
for line in git_output:
ignore = False
Expand Down

0 comments on commit 381c9b1

Please sign in to comment.