Objectchooser preview #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was moved from sugar expandedentry.py to be available to use in other places. Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
|
This needs to be applied together with sugarlabs/sugar#48 |
|
get_preview_pixbuf looks wrong in module sugar3.datastore.datastore . It should be added as a submodule under sugar3.graphics. |
|
Who are the other users that justify the move from sugar to toolkit? Please tell in the commit message. Other than that, patch looks great! |
akskumarnot
pushed a commit
to akskumarnot/sugar-toolkit-gtk3
that referenced
this pull request
Jan 26, 2014
Ubuntu and Debian need to pull pep8 from github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.