Don't add a label on RadioToolButton when set icon_widget - Fixes #4875

[godiard]

When we use set_icon_widget(), GtkToolButton set a private property
contents_invalid = TRUE [1], and gtk_tool_button_construct_content [2]
is called. Then if the label widget not exist, a GtkLabel is added.
This is a problem for us, by example in the Clipboard buttons in the frame.
By adding a empty Gtk.Box instead of a label, we avoid the label creation.

But as this is a internal implementation of Gtk, can change in the future,
in fact the issue is not visible with Gtk < 3.16

This patch is based in a pr sent by Sam Parkinson

[1] https://github.com/GNOME/gtk/blob/master/gtk/gtktoolbutton.c#L1415
[2] https://github.com/GNOME/gtk/blob/master/gtk/gtktoolbutton.c#L357

[godiard]

This is based on @samdroid-apps pr sugarlabs/sugar#552
but solving the issue in the toolkit is better to avoid the problem in other places.

[samdroid-apps]

Does this effect the buttons that have a label (the ones in toolbar
overflow menus)?

On Thu, 9 Jul 2015 3:29 am Gonzalo Odiard notifications@github.com wrote:

This is based on @samdroid-apps https://github.com/samdroid-apps pr
sugarlabs/sugar#552 sugarlabs/sugar#552
but solving the issue in the toolkit is better to avoid the problem in
other places.

—
Reply to this email directly or view it on GitHub
#239 (comment)
.

[godiard]

@samdroid-apps, only radiotoolbuttons. In what case are you thinking?

[samdroid-apps]

I probably wasn't thinking.

Merged.