Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GTK2 activities run properly outside Sugar. #3

Merged
merged 1 commit into from
Jul 10, 2016

Conversation

icarito
Copy link
Contributor

@icarito icarito commented May 17, 2016

  • Proper themes and scaling overriding XSETTINGS daemon
  • Set activity icon
  • Scale activity window in accordance to workarea
  • Find acitivity root

- Proper themes and scaling overriding XSETTINGS daemon
- Set activity icon
- Scale activity window in accordance to workarea
- Find acitivity root
@icarito
Copy link
Contributor Author

icarito commented May 27, 2016

Can't we merge this?

@icarito icarito reopened this May 27, 2016
@icarito icarito added enhancement and removed bug labels May 27, 2016
@samdroid-apps
Copy link
Contributor

Didn't you already merge this?

@icarito
Copy link
Contributor Author

icarito commented May 27, 2016

No, this is completely different. Without this, GTK2 activities look horrible outside Sugar. There is a very similar (merged) pull request in sugar-toolkit-gtk3 - this one is the equivalent for sugar-toolkit. :-)

@samdroid-apps
Copy link
Contributor

I will test this soon. I just discovered that I don't have the pygobject headers installed. It will miss today unstable sorry.

1 similar comment
@samdroid-apps
Copy link
Contributor

I will test this soon. I just discovered that I don't have the pygobject headers installed. It will miss today unstable sorry.

@icarito
Copy link
Contributor Author

icarito commented Jun 21, 2016

I don't think you need headers, I think if you use sugar-build you can use osbuild shell...

@icarito
Copy link
Contributor Author

icarito commented Jul 6, 2016

I just installed osbuild and can give a way to test this patch:

  • run osbuild shell
  • cd turtleart
  • sugar-activity

Without this patch it will look really bad.

@davelab6
Copy link

davelab6 commented Jul 6, 2016

@samdroid-apps when do you plan to cut the next unstable release?

@samdroid-apps
Copy link
Contributor

@icarito sorry about not reviewing this, I will get it done for tommorow

@davelab6 I have some time tomorrow to do a release. I'm going to make some tarballs with some webkit2 patches as well - so that we can test a sugar without a webkit1 dep.

@samdroid-apps samdroid-apps merged commit 1a80668 into sugarlabs:master Jul 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants