-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jarabe, extensions - remove GConf compatibility #792
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another make-work project for developers. The best solution would be to
return to the config file in /home/olpc/.sugar/defaults. That has no
dependency on upstream and is therefore immune from these diktats.
Tony
…On Monday, 26 March, 2018 05:59 AM, James Cameron wrote:
*
removes GConf dependency,
*
breaks GTK+ 2 activities; this version of Sugar will cause
traceback and fail to start for any activity using a GConf schema
to read configuration values for; age, gender, nick, user colour,
collaboration server, backup server, automatic power management.
Untested.
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#792
Commit Summary
* jarabe, extensions - remove GConf compatibility
File Changes
* *M* configure.ac
<https://github.com/sugarlabs/sugar/pull/792/files#diff-0> (11)
* *M* data/Makefile.am
<https://github.com/sugarlabs/sugar/pull/792/files#diff-1> (7)
* *M* data/org.sugarlabs.gschema.xml
<https://github.com/sugarlabs/sugar/pull/792/files#diff-2> (5)
* *D* data/sugar-schemas.convert
<https://github.com/sugarlabs/sugar/pull/792/files#diff-3> (69)
* *D* data/sugar.schemas.in
<https://github.com/sugarlabs/sugar/pull/792/files#diff-4> (491)
* *M* extensions/cpsection/aboutme/model.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-5> (15)
* *M* extensions/cpsection/network/model.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-6> (11)
* *M* extensions/cpsection/power/model.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-7> (5)
* *M* src/jarabe/desktop/schoolserver.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-8> (7)
* *M* src/jarabe/intro/__init__.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-9> (6)
* *M* src/jarabe/intro/agepicker.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-10> (5)
* *M* src/jarabe/intro/genderpicker.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-11> (6)
* *M* src/jarabe/intro/window.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-12> (10)
* *M* src/jarabe/main.py
<https://github.com/sugarlabs/sugar/pull/792/files#diff-13> (106)
Patch Links:
* https://github.com/sugarlabs/sugar/pull/792.patch
* https://github.com/sugarlabs/sugar/pull/792.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#792>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAULkvLKzn1-QCfA90dFbQ6N1b6NGHNyks5tiGeXgaJpZM4S6fTR>.
|
Returning to a defaults file would break compatibility with settings made by builders or shell scripts. It would also lose locking, and settings change notification. We could also avoid GTK+ and use something more stable like X or Qt, but such a port would be a huge make-work. With the withdrawal of GTK+ 2 we lose the use of many abandoned activities. |
quozl
force-pushed
the
2018-03-26-no-gconf
branch
from
March 28, 2018 03:49
3bdccf9
to
7945c5d
Compare
GConf compatibility support in Sugar allowed activities to read or be notified of changes to age, gender, nick, user colour, collaboration server, backup server, or automatic power management. Redundant code updated GConf values at the same time as updates to Gio.Settings values. Remove GConf from Sugar; - remove the autoconf rules, - remove the Makefile rules, - remove the schema conversion for upgrades from GTK+ 2 Sugar, - remove the gsettings-migrated setting key, - remove the GConf schema from POTFILES.in, - remove the GConf schema, - remove redundant code for GConf value updates, - remove migration from GConf to Gio.Settings. Warning: may break some activities. May cause default values to be used, traceback, or fail to start for any activity using the removed GConf schema to read the removed configuration values for; age, gender, nick, user colour, collaboration server, backup server, and automatic power management. Fix GTK+ 2 activities by porting to GTK+ 3 and Gio.Settings. Fix GTK+ 3 activities by porting from GConf to Gio.Settings. Tested on Ubuntu 16.04. Tested on Ubuntu 18.04 with autogen.sh, distcheck, install, uninstall.
quozl
force-pushed
the
2018-03-26-no-gconf
branch
from
April 1, 2018 23:55
7945c5d
to
f06ce70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GConf compatibility support in Sugar allowed activities to read or be notified of changes to age, gender, nick, user colour, collaboration server, backup server, or automatic power management. Redundant code updated GConf values at the same time as updates to Gio.Settings values.
Remove GConf from Sugar;
remove the autoconf rules,
remove the Makefile rules,
remove the schema conversion for upgrades from GTK+ 2 Sugar,
remove the gsettings-migrated setting key,
remove the GConf schema,
remove redundant code for GConf value updates,
remove migration from GConf to Gio.Settings.
Warning: may break some activities. May cause default values to be used, traceback, or fail to start for any activity using the removed GConf schema to read the removed configuration values for; age, gender, nick, user colour, collaboration server, backup server, and automatic power management. Fix GTK+ 2 activities by porting to GTK+ 3 and Gio.Settings. Fix GTK+ 3 activities by porting from GConf to Gio.Settings.
Tested on Ubuntu 16.04.