Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jarabe, extensions - remove GConf compatibility #792

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

quozl
Copy link
Contributor

@quozl quozl commented Mar 26, 2018

GConf compatibility support in Sugar allowed activities to read or be notified of changes to age, gender, nick, user colour, collaboration server, backup server, or automatic power management. Redundant code updated GConf values at the same time as updates to Gio.Settings values.

Remove GConf from Sugar;

  • remove the autoconf rules,

  • remove the Makefile rules,

  • remove the schema conversion for upgrades from GTK+ 2 Sugar,

  • remove the gsettings-migrated setting key,

  • remove the GConf schema,

  • remove redundant code for GConf value updates,

  • remove migration from GConf to Gio.Settings.

Warning: may break some activities. May cause default values to be used, traceback, or fail to start for any activity using the removed GConf schema to read the removed configuration values for; age, gender, nick, user colour, collaboration server, backup server, and automatic power management. Fix GTK+ 2 activities by porting to GTK+ 3 and Gio.Settings. Fix GTK+ 3 activities by porting from GConf to Gio.Settings.

Tested on Ubuntu 16.04.

@tony37
Copy link

tony37 commented Mar 26, 2018 via email

@quozl
Copy link
Contributor Author

quozl commented Mar 26, 2018

Returning to a defaults file would break compatibility with settings made by builders or shell scripts. It would also lose locking, and settings change notification.

We could also avoid GTK+ and use something more stable like X or Qt, but such a port would be a huge make-work. With the withdrawal of GTK+ 2 we lose the use of many abandoned activities.

GConf compatibility support in Sugar allowed activities to read or be
notified of changes to age, gender, nick, user colour, collaboration
server, backup server, or automatic power management.  Redundant code
updated GConf values at the same time as updates to Gio.Settings values.

Remove GConf from Sugar;

- remove the autoconf rules,

- remove the Makefile rules,

- remove the schema conversion for upgrades from GTK+ 2 Sugar,

- remove the gsettings-migrated setting key,

- remove the GConf schema from POTFILES.in,

- remove the GConf schema,

- remove redundant code for GConf value updates,

- remove migration from GConf to Gio.Settings.

Warning: may break some activities.  May cause default values to be
used, traceback, or fail to start for any activity using the removed
GConf schema to read the removed configuration values for; age, gender,
nick, user colour, collaboration server, backup server, and automatic
power management.  Fix GTK+ 2 activities by porting to GTK+ 3 and
Gio.Settings.  Fix GTK+ 3 activities by porting from GConf to
Gio.Settings.

Tested on Ubuntu 16.04.

Tested on Ubuntu 18.04 with autogen.sh, distcheck, install, uninstall.
@quozl quozl merged commit 38b173d into sugarlabs:master Apr 1, 2018
@quozl quozl deleted the 2018-03-26-no-gconf branch April 1, 2018 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants