Fix control panel search focus issue - SL #3188 #168
Conversation
Check if the window is active. Fixes #3188 Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
|
I suspect the problem is that ControlPanel is a modal dialog, but not a proper one. A modal dialog should not allow you to activate another window in the same process, which seem to be the case here. We are only calling show() on it, we should also block in an event loop. The easier way is to do that is to use GtkDialog run(), otherwise I think it's possible to do it for a GtkWindow too but it's a bit more complicated. Can we make ControlPanel a GtkDialog or is there a good reason for it to be GtkWindow? |
|
Honestly, I don't know... |
|
Looking at gtk_dialog_run it seems it might be enough to do something like this after the show() loop = GObject.main_loop_new() |
|
I have tried your proposal (attached patch) but show the same defect than Can you tell me if the attached patch is what you said or if I Is based in the code from Gtkdialog On Fri, Nov 29, 2013 at 5:52 PM, Daniel Narvaez notifications@github.comwrote:
Gonzalo Odiard |
|
No patch attached, I guess github gets rid of it. |
|
Sending by traditional email :) On Wed, Dec 4, 2013 at 4:10 PM, Daniel Narvaez notifications@github.comwrote:
Gonzalo Odiard |
|
Yes I meant something like that. I can't look deeper into it right now, but give me couple of days and I'll On 4 December 2013 20:18, Gonzalo Odiard godiard@gmail.com wrote:
Daniel Narvaez |
|
A additional note. With this main_loop patch, I don't know if I did On Wed, Dec 4, 2013 at 4:20 PM, Daniel Narvaez dwnarvaez@gmail.com wrote:
Gonzalo Odiard |
|
I don't think this is related to modality and clicking outside the control panel at all. Try to just start the control panel and type something (without focusing search), you will get the same behavior. The issues are caused by this code, if you remove it, the UI behaves sanely https://github.com/sugarlabs/sugar/blob/master/src/jarabe/controlpanel/gui.py#L205 That feels like an hack to me. I'm not sure if it can be made to work. I'd rather just focus the entry when opening the window/coming back from sections... Or something like that. |
|
Uff ignore that comment, more debugging needed. |
|
Ok, I finally understood what is going. By default gtk selects the entry content on grab_focus. When we click out of the window, the modal dialog loses focus, though keyboad is grabbed and we get key press events. Thus every time a key is pressed we try to grab focus. That doesn't really affect focus, presumably because you can't grab focus inside an unfocused window, but it does cause the entry to be cleared. This is probably a gtk bug but it's quite a corner case. Now, with that explained, I think your patch is a reasonable solution. |
|
Pushed |
Check if the window is active.
Fixes #3188
Signed-off-by: Gonzalo Odiard gonzalo@laptop.org