Implement filter by mime types used by activities in the objectchooser #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a optative parameter use_mime_types to ObjectChooser constructor.
If this parameter is True, the parameter what_filter should be a
bundle_id, and the filter will be set to the collection of mime types
the activity can manage, as configured in the activity.info file.
The title in the toolbar is changed, and the what_filter combo
is not visible when this parameter is used.
A example of use is:
chooser = ObjectChooser(parent=self, what_filter=self.get_bundle_id(),
use_mime_types=True)
This patch need a change in sugar-toolkit-gtk3 because a paramter was
added.
Signed-off-by: Gonzalo Odiard <gonzalo@laptop.org>
|
Comment: I am not in love with the name of the parameter "use_mime_types". If there are better ideas, we can change it. |
|
Maybe filter_type generic/mime/activity or something? |
|
+1 to filter_type= more future proof |
|
Ok. Closing to change the api |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a optative parameter use_mime_types to ObjectChooser constructor.
If this parameter is True, the parameter what_filter should be a
bundle_id, and the filter will be set to the collection of mime types
the activity can manage, as configured in the activity.info file.
The title in the toolbar is changed, and the what_filter combo
is not visible when this parameter is used.
A example of use is:
chooser = ObjectChooser(parent=self, what_filter=self.get_bundle_id(),
use_mime_types=True)
This patch need a change in sugar-toolkit-gtk3 because a paramter was
added.
Signed-off-by: Gonzalo Odiard gonzalo@laptop.org