Rework the wireless control panel section to respect non-wireless connec... #228
Conversation
…nections Fixes #4410 https://bugs.sugarlabs.org/ticket/4410 The 'Discard network history' button is peculiar to Sugar, and is destructive to all non-wireless connections, despite being in the 'Wireless' section of the control panel. Relabel the code variables and functions to be specific to wireless connections. Recode the functions to exclude non-wireless connections. Relabel the 'Radio' box instructions and 'Discard ...' button to avoid confusion over their state and actions. If wireless hardware is not present on the system, the 'Wireless' section of the control panel is excluded. The availability of wireless hardware is tested with the kernel's sys filesystem because, with the radio disabled, wireless devices are not exposed in the NetworkManager API and it would be inappropriate to turn the radio on--just to see if one is present.
|
[DESIGN] discussion thread started at http://lists.sugarlabs.org/archive/sugar-devel/2014-January/046900.html |
|
Reviewed-by: James Cameron quozl@laptop.org Like it. |
|
Where are you testing this? In Fedora 20, the list of devices seems to be available even if wireless is disabled I have not tested with the dbus service directly, but I'd expect nmcli to ultimately be using the dbus service to get this info. |
|
It seems like the code is handling adhoc networks specially, but I didn't find an explanation of that change. Can you please elaborate on it? |
|
I'm finding a bit difficult to review this because there is a lot of code moving. I want to be extra careful here to not risk to regress something essential as wifi. I suggest that we split it up in two commits 1 Change the networks the button applies to. |
|
Closing to divide and resubmit sequentially as discussed here, |
...tions
Fixes #4410 https://bugs.sugarlabs.org/ticket/4410
The 'Discard network history' button is peculiar to Sugar, and
is destructive to all non-wireless connections, despite being in
the 'Wireless' section of the control panel.
Relabel the code variables and functions to be specific to
wireless connections.
Recode the functions to exclude non-wireless connections.
Relabel the 'Radio' box instructions and 'Discard ...' button
to avoid confusion over their state and actions.
If wireless hardware is not present on the system, the 'Wireless'
section of the control panel is excluded.
The availability of wireless hardware is tested with the kernel's
sys filesystem because, with the radio disabled, wireless devices
are not exposed in the NetworkManager API and it would be
inappropriate to turn the radio on--just to see if one is present.
Wireless hardware present:
No wireless hardware:
