Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microformat updater: set cache header #246

Closed
wants to merge 1 commit into from
Closed

Microformat updater: set cache header #246

wants to merge 1 commit into from

Conversation

godiard
Copy link
Contributor

@godiard godiard commented Feb 14, 2014

wiki.laptop.org, where the pages used to update the activities are
located, usually serve old cached pages. We can avoid that
setting the header Cache-Control' = 'max-age=600',
and be sure the page is not older than 10 minutes.

Signed-off-by: Gonzalo Odiard godiard@sugarlabs.org

wiki.laptop.org, where the pages used to update the activities are
located, usually serve old cached pages. We can avoid that
setting the header Cache-Control' = 'max-age=600',
and be sure the page is not older than 10 minutes.

Signed-off-by: Gonzalo Odiard <godiard@sugarlabs.org>
@dnarvaez
Copy link
Contributor

Maybe I'm missing something but isn't this just a work around for a server issue? Since we control the server, I'd rather fix that.

@tchx84
Copy link
Member

tchx84 commented Feb 14, 2014

We were discussing this, and is not the case that we can control all the servers along the way. Therefore, We were thinking on alternatives on how to get a decent trade off between "clients getting updates sooner" and "servers not getting heavy traffic over resources that doesn't change very often". And this was a good alternative.

@jvonau
Copy link
Contributor

jvonau commented Feb 14, 2014

Would this not have some effect at the schools that have to pass all the traffic through a proxy before reaching wiki.laptop.org? What if a deployment wanted to use an alternate location for the microformat webpage, such as on a schoolserver, would this change not effect that situation also? I'm with dnarvaez on this, it's a server side issue http://dev.laptop.org/ticket/10722, but does SL really have control over olpc's servers or the proxy in front of the server in question?

@walterbender
Copy link
Member

No matter what we decide here, we should start providing a SL service for
updates that is under our control. The state of maintenance of the OLPC
servers is in some doubt long term.

On Fri, Feb 14, 2014 at 11:07 AM, Jerry Vonau notifications@github.comwrote:

Would this not have some effect at the schools that have to pass all the
traffic through a proxy before reaching wiki.laptop.org? What if a
deployment wanted to use an alternate location for the microformat webpage,
such as on a schoolserver, would this change not effect that situation
also? I'm with dnarvaez on this, it's a server side issue
http://dev.laptop.org/ticket/10722, but does SL really have control over
olpc's servers or the proxy in front of the server in question?

Reply to this email directly or view it on GitHubhttps://github.com//pull/246#issuecomment-35097068
.

Walter Bender
Sugar Labs
http://www.sugarlabs.org

@jvonau
Copy link
Contributor

jvonau commented Feb 14, 2014

Changing client side code to compensate for a single website's behavior when the client side can be pointed to any other server just feels wrong to me.

@godiard
Copy link
Contributor Author

godiard commented Feb 14, 2014

@jvonau , we discussed it extensively in irc, and concluded this approach is the best, because we solve the issue for deployments not using wiki.laptop.org too (like Paraguay as commented by @tchx84 )

@jvonau
Copy link
Contributor

jvonau commented Feb 14, 2014

That is funny I don't see the conversation on IRC, was this in a private chat maybe? Perhaps this should be discussed on the mailinglists (both SL's sugar-devel and olpc's devel) to gather greater community input.

@tchx84
Copy link
Member

tchx84 commented Feb 14, 2014

@jvonau no, only a few requests (the first ones) each 10 minutes would need to reach the final server... the rest of the requests would simply use the cached version of the resource, as it is renewed. That is it a trade-off: the clients gets relatively new version of the resource while the servers can still cache most of the traffic.

@jvonau
Copy link
Contributor

jvonau commented Feb 14, 2014

@jvonau
Copy link
Contributor

jvonau commented Feb 14, 2014

How about a "force" button added to control panel that would add the Cache-Content header on demand and retry in place of a wholesale change? The advantage is only one user would need to force the refresh of the cache for the rest of the other users using the same pathway through the same proxy. Think this might be a fair trade-off.

@dnarvaez
Copy link
Contributor

Well, we did considerable work client side to have transparent automatic updates, I think we should keep the UX that way.

As I said on IRC I'm fine with going with this if tch and gonzalo feels strongly that it's the way to go. Let's just add a comment explaining the rationale. From the current comment it's not clear why we couldn't just fix dev.laptop.org.

@godiard
Copy link
Contributor Author

godiard commented Feb 15, 2014

Ok, pushed with a better description.

@godiard godiard closed this Feb 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants