Activity notifications try 4 #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manuq Quick design question: Where should the Stop button be placed? |
|
@tchx84 the Stop button is always expected at the end (of a toolbar or palette). So that should be preserved. The designs from Gary had the Stop at the end too. |
|
Updated api pr - sugarlabs/sugar-toolkit-gtk3#114 |
|
with minor fixes, merged. Thanks a lot Sam! Outstanding work from the very beginning :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @manuq
(Pretty much the same as last, but rebased to the new code)
toolkit prsugarlabs/sugar-toolkit-gtk3#114I added the ability for activities to do the notification dance. The ui is just the systems notification ui but merged with the activity palette. I added a activity.notify function in the toolkit. Here is a picture (all else is shared with other notifications):