Adhoc enhacements try2 #375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set _last_channel so it will re-connect to the last ad-hoc network it was connected before, during the same sugar session. Unset _last_channel when the user explicitly disconnects from the ad-hoc network, so it will forget about the last network it was connected during the same sugar session. Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
Add a gconf value to determine whether or not ad-hoc networks should autoconnect. This gconf value will be ignored if the user explicitly connects to a ad-hoc network, for the rest of the session. It will be taken into account again, if the user explicitly disconnect from the ad-hoc network. Signed-off-by: Martin Abente Lahaye <tch@sugarlabs.org>
|
The first patch sounds fine from a release management perspective. It's more of a bugfix. The second one breaks string freeze and probably feature freeze too. I think it would need to be discussed and approved also by the localization team. |
|
Fair enough, I will separate both patches in different PR as both have different requirements for their inclusion. |
|
I have sent a separate PR for the first change, #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two patches I made to ad-hoc networks autoconnect behaviour.
The first change, simplifies the autoconnect logic, from a "connect to the first available network you find, or connect to 1 otherwise" to a "connect to the last network you used during this session, or connect to 1 otherwise". This change was made as a requirement from Australia deployment, as the previous behavior seemed too unpredictable for users.
The second change allow us to disable Ad-hoc auto-connect using a gsettings value. Auto-connect option will be enabled by default. When disabled, Sugar will no longer auto-connect until the user explicitly connects to an Ad-hoc network (this is to cover suspend/resume scenarios). When the user explicitly disconnects from the Ad-hoc network, auto-connect will be disabled again.