Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select autocompleted activity search text #476

Closed

Conversation

samdroid-apps
Copy link
Contributor

This means that slow typers who are not looking at the screen will
will overwrite the autocomplete, instead of adding to it.

Thanks to @quozl for reporting and suggesting the solution.

This means that slow typers who are not looking at the screen will
will overwrite the autocomplete, instead of adding to it.

Thanks to Quozl for reporting and suggesting the solution.
@tchx84
Copy link
Member

tchx84 commented Feb 26, 2015

Hello @samdroid-apps , can you describe some use cases so I can test?

@samdroid-apps
Copy link
Contributor Author

Try becoming a find an peck typer for a minute. So, type in the activity name slowly with 1 finger and looking at the keyboard. With the old version the user would end up with something like "Browsewse" in the search bar.

@quozl
Copy link
Contributor

quozl commented Feb 27, 2015

Yes, that's a good example. A tester should test with independent use cases as well, that's what I did to detect the problem. Perhaps tchx84 hasn't been able to review the patch quickly because the commit doesn't give an example of the problem. Hopefully that isn't needed.

@godiard
Copy link
Contributor

godiard commented Mar 2, 2015

Tested and is a good fix, specially thinking in our younger users. Merged.

@godiard godiard closed this Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants