Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro: don't try setup non existent page - Fixes #4872 #555

Merged
merged 1 commit into from Jul 19, 2015

Conversation

godiard
Copy link
Contributor

@godiard godiard commented Jul 10, 2015

No description provided.

@tchx84
Copy link
Member

tchx84 commented Jul 13, 2015

@quozl can you describe how to reproduce this?

@tchx84 tchx84 added the bug label Jul 13, 2015
@quozl
Copy link
Contributor

quozl commented Jul 14, 2015

@tchx84, no. shell.log was captured as part of evaluating a different problem, so this was an incidental discovery. I do not think it needs to be reproduced.

@godiard
Copy link
Contributor Author

godiard commented Jul 14, 2015

@quozl, @tchx84, The issue will not happen every time, because done() emit a signal, then that processing is async. If the signal is processed fast enough, the window is closed before try to prepare the wrong page. The fix is clear, if is the last page, we can't process one page more.

@samdroid-apps
Copy link
Contributor

Does not break normal setup paging.

Merged.

@samdroid-apps samdroid-apps merged commit 24b7d99 into sugarlabs:master Jul 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants