Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify library version prior to import, fixes #4900 #609

Merged

Conversation

samdroid-apps
Copy link
Contributor

Replaces #600, no longer assumes Maliit is installed.

Gi has been emitting warnings into the log to do this for some
time now. Not doing this has also caused bugs, such as #4900.

Ticket URL https://bugs.sugarlabs.org/ticket/4900

Gi has been emitting warnings into the log to do this for some
time now.  Not doing this has also caused bugs, such as #4900.

Ticket URL <https://bugs.sugarlabs.org/ticket/4900>
@samdroid-apps samdroid-apps added this to the 0.108 Features milestone Nov 5, 2015
@i5o
Copy link
Contributor

i5o commented Nov 5, 2015

Testing

@i5o
Copy link
Contributor

i5o commented Nov 5, 2015

shell.log http://paste.fedoraproject.org/287120/67079611
I think we will need to change all instances?

org.laptop.WebActivity-1.log http://paste.fedoraproject.org/287121/70802114 (just sharing it, no idea abou what happened).

@quozl
Copy link
Contributor

quozl commented Nov 5, 2015

For your shell.log at http://paste.fedoraproject.org/287120/67079611,

Check the patch is properly applied?

Line 57 of src/jarabe/main.py is either the import Gtk of the pre-patch condition, or the require_version in the post-patch condition.

@i5o
Copy link
Contributor

i5o commented Nov 29, 2015

I don't have fedora right now, but I will get it ASAP and report back

@samdroid-apps
Copy link
Contributor Author

@samdroid-apps
Copy link
Contributor Author

Could we look into getting this done for 110? This patch fixes so much log noise, and log noise is very painful for development.

@davelab6
Copy link
Contributor

davelab6 commented Apr 3, 2016

Added to https://wiki.sugarlabs.org/go/0.110/Feature_List - I see there is a Github issue tracker milestones that this is part of, but it seems Github Issues is deactivated...

@samdroid-apps
Copy link
Contributor Author

Yes, we use trac for issues. The milestones feature is only available to the github org members anyways.

I will also make the feature as orphaned. IDK If I will do it for this cycle, I don't know if I will have time yet. You are welcome to give it a go though.

@davelab6
Copy link
Contributor

davelab6 commented Apr 3, 2016

we use trac for issues

I don't think we should, and started a thread on that topic, http://lists.sugarlabs.org/archive/sugar-devel/2016-April/051788.html :)

@quozl
Copy link
Contributor

quozl commented Apr 3, 2016

Log noise is also painful for deployment, as it scales power and disk usage across a large number of devices. I'm also in favour of this patch.

@samdroid-apps samdroid-apps merged commit 171cddb into sugarlabs:master Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants