Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing "Decrease and increase size" option with the Size slider #401

Open
jaskiratsingh2000 opened this issue May 4, 2018 · 8 comments

Comments

@jaskiratsingh2000
Copy link
Contributor

The two options within the TB program showing "Decrease Size" and "Increase Size" of blocks can be replaced by the slider for decreasing and increasing size of blocks as it would open the option for the users to adjust the size of blocks according to there needs instead of being limited to only one reduced size.
the blocks become either too small or very large so by adding this option they will be able to add intermediate sizes also.

@Aniket21mathur
Copy link
Contributor

@jaskirat2000 cannot we just change the scale by which the block size is increased or decreased on clicking the "Increase Size" or "Decrease Size" options.

@jaskiratsingh2000
Copy link
Contributor Author

jaskiratsingh2000 commented Dec 22, 2018 via email

@Aniket21mathur
Copy link
Contributor

I totally agree with you @jaskirat2000, but cannot we just change the scale so that on every increase or decrease the size of blocks is changed by "0.1", this will allow the users to use the intermediate sizes which previously they cannot.At present the blockSize is increased or decreased by "1" which results in massive change in size.And also "0.1" change makes a small difference in blockSize as seen on screen.

@jaskiratsingh2000
Copy link
Contributor Author

jaskiratsingh2000 commented Dec 22, 2018 via email

@walterbender
Copy link
Member

I have seen no evidence that the discrete sizes present a problem for any use case.

@jaskiratsingh2000
Copy link
Contributor Author

jaskiratsingh2000 commented Dec 22, 2018 via email

@Aniket21mathur
Copy link
Contributor

So do we have to make any changes to it or leave it as it is?

@walterbender
Copy link
Member

Please leave it until a demonstrable need to change it is offered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants