Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad path for background image in minified css #173

Closed
walterbender opened this issue Dec 8, 2017 · 3 comments
Closed

bad path for background image in minified css #173

walterbender opened this issue Dec 8, 2017 · 3 comments
Labels

Comments

@walterbender
Copy link
Member

In airspace.css, the background image is specified as ../assets/bg6.jpg
When that css file is minified, the minified file is put into the minified subdirectory.

This breaks the relative path resolution.

404 file not found: www.sugarlabs.org/css/assets/bg6.jpg

Tested on Chrome and Firefox on Fedora 27

Seems there are three approaches we could take:

(1) move the minified files into css, giving them a new name, e.g., airspace.minified.css (This would require a change to _layouts/base.html, where the minified css is accessed.);

(2) modify the path in the minified code (there are actually four occurrences of relative path names that probably should be changed) but this would probably lead to long-term maintenance issues as the expectation is that minified files are not changed from their originals except in format;

(3) add a symlink or copy the asset directory into css (This seems both clumsy, error prone, and obscure, again presenting long-term maintenance issues.)

I would argue that the best choice forward is no. 1 above.

There maybe other options. And, reportedly the background image somehow works on some version of Safari, although I cannot image how it could work.

@walterbender
Copy link
Member Author

walterbender commented Dec 8, 2017

FWIW, in https://github.com/geekrypter/sugarLabsWebsiteRedesign/blob/master/css/minified/airspace.css option 2 was used: the relative path in the minified file is ../../assets/

@walterbender
Copy link
Member Author

It was just reported that the current code does not work on Safari -- it was a cached version.

@quozl
Copy link
Contributor

quozl commented Oct 9, 2019

Stale, closing. We have since stopped minifying our derivative copy of airspace.css.

@quozl quozl closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants