feat: Support wasm32 #119
feat: Support wasm32 #119
Conversation
| @@ -4,7 +4,8 @@ pub use self::memory::MemorySessionStore; | |||
| pub(crate) use super::Session; | |||
| use async_trait::async_trait; | |||
|
|
|||
| #[async_trait] | |||
| #[cfg_attr(target_arch = "wasm32", async_trait(?Send))] | |||
There was a problem hiding this comment.
It might be useful to mention this change (the Send bound on whatever this is effecting now being optional for wasm32-* targets) in the atrium-api changelog (for the public traits that are altered).
| @@ -29,7 +29,8 @@ where | |||
| } | |||
|
|
|||
| /// An abstract HTTP client. | |||
| #[async_trait] | |||
| #[cfg_attr(target_arch = "wasm32", async_trait(?Send))] | |||
There was a problem hiding this comment.
Ditto, it would be useful to mention this in the atrium-xrpc changelog (for the public traits that are changed).
| isahc = ["dep:isahc"] | ||
| reqwest-native = ["reqwest/native-tls"] | ||
| reqwest-rustls = ["reqwest/rustls-tls"] |
There was a problem hiding this comment.
It would be useful to mention the removal of these feature flags (and addition of the new ones) in the atrium-xrpc-client changelog.
| surf = ["dep:surf"] | ||
|
|
||
| [dev-dependencies] | ||
| [target.'cfg(target_arch = "wasm32")'.dependencies] | ||
| reqwest.workspace = true |
There was a problem hiding this comment.
This makes reqwest non-optional on wasm32, which is a little odd but I guess makes sense given that atrium-xrpc-client is completely empty when no features are enabled. If a non-reqwest backend gains wasm32 support then changing this to be default-enabled instead at that time is fine.
|
Thanks for reviewing! |
resolve #116
async_traitdepending on whethertarget_arch = "wasm32"or not.wasm-pack --testatrium-xrpc-client's features