-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SQLAlchemy pin from >=1.4.31,<2.0.0 -> >=2.0.0 #11
Conversation
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Let me try running the tests. Also, I'll see if I can add a pytest runner to the CI to automate the process. |
Hi @suhailrehman! Any updates so far? |
There's an API change that seems to be breaking tests:
|
@anmyachev I've made the required changes to support a newer SQLalchemy version. What do you think the best way is to integrate the changes now? Can I commit to your repo to keep things in this PR? Please give me permissions if that makes sense, or let me know what the best option is. (I've never had to commit back into an external PR of my repo) |
I've merged the changes into main. Stay tuned for a new release today |
@suhailrehman I don't mind if you add your commits to my branch (here and in the future). Apparently I forgot to provide you with this opportunity through the
Thanks a lot! |
sqlalchemy 2.0.0 is the minimum supported version for pandas 2.2.0. I started to adopt a new version of pandas (modin-project/modin#6907) and ran into dependency incompatibility.
Hi @suhailrehman, what do you think about updating sqlalchemy versions?
Please note: although I changed the pin, I did not manually test the changes.