Flip arguments of run* eval* and exec* functions #95
Conversation
src/Control/Eff/State/OnDemand.hs
Outdated
| runStateR :: Eff (Writer s ': Reader s ': r) w -> s -> Eff r (w,s) | ||
| runStateR m0 s0 = loop s0 m0 | ||
| runStateR :: s -> Eff (Writer s ': Reader s ': r) w -> Eff r (w,s) | ||
| runStateR s m = loop s m |
There was a problem hiding this comment.
@power-fungus please fix the name shadowing error. i believe this is triggering it
There was a problem hiding this comment.
This should be indeed the issue. However, using stack build this does not get detected. Is there a way to reduce the complexity of the Makefile by using stack? stack builds is fine, but does not report the shadowing errors. I don't understand the Makefile well enough to transform that. make build fails on my machine with
cabal sandbox init
Writing a default package environment file to
/home/power-fungus/Documents/haskell/extensible-effects/cabal.sandbox.config
Using an existing sandbox located at
/home/power-fungus/Documents/haskell/extensible-effects/.cabal-sandbox
cabal clean
cleaning...
cabal install --only-dependencies --enable-tests --enable-benchmarks
Warning: The package list for 'hackage.haskell.org' does not exist. Run 'cabal
update' to download it.
Resolving dependencies...
cabal: Could not resolve dependencies:
rejecting: extensible-effects-2.5.2.0:!bench (constraint from config file,
command line flag, or user target requires opposite flag selection)
trying: extensible-effects-2.5.2.0:*bench
unknown package: test-framework-th (dependency of
extensible-effects-2.5.2.0:*bench)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: extensible-effects,
extensible-effects-2.5.2.0:bench, test-framework-th
Note: when using a sandbox, all packages are required to have consistent
dependencies. Try reinstalling/unregistering the offending packages or
recreating the sandbox.
There was a problem hiding this comment.
Also, it is possible to travis-cache the dependencies (which I know how to do for stack) but not for cabal with sandboxes
There was a problem hiding this comment.
@power-fungus a couple of points:
make buildwill fail unless a particular version ofcabalandghcare in scope. when developing, i bring those in vianixby runningnix-shell(or a variant)- happy to move
makebuild steps to usestackinstead. patches welcome! (same fortravis-cacheissue)
src/Control/Eff/Writer/Strict.hs
Outdated
| {-# INLINE execWriter #-} | ||
|
|
||
| -- | Handle Writer requests, using a List to accumulate values and discard the | ||
| -- effect result. |
There was a problem hiding this comment.
@power-fungus minor nitpick, but could we make the documentation consistent with execState etc? e.g. focusing on how the monoidal value is handled (instead of the result of computation). something like Handle Writer requests, using a List to accumulate values and returning the final accumulated values
if you agree this helps, could you tweak? if you don't, please ignore this
There was a problem hiding this comment.
good point. I did not think of that wording.
|
I will also address the next compilation errors in benchmarks |
resolves #94.
This flips arguments of
run*,eval*andexec*functions of State, Reader and Writer. The other effects are left untouched intentionally. Mainly because I understand them not well enough.There are also new
eval*Writerfunctions that were "missing".