Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

Investors do not increase consumption of cigars #13

Closed
GrumpyCatastrophe opened this issue May 12, 2019 · 5 comments
Closed

Investors do not increase consumption of cigars #13

GrumpyCatastrophe opened this issue May 12, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@GrumpyCatastrophe
Copy link

In game cigars are used by investors and obreros. In calculator, investors do not increase consumption of cigars, while obreros do. Most likely connected to the fact that cigars are both basic and luxury items.
cigars

@tbfuerst tbfuerst added the bug Something is obviously not working label May 12, 2019
@suhrmann
Copy link
Owner

Thank you for the issue. We weren't aware that cigars are basic and luxury. We are currently investigating the consequences for the calculator.

suhrmann added a commit that referenced this issue May 13, 2019
+ add support to calculate basic and luxury demands (Cigars: basic for investors; luxury for obreros)
suhrmann added a commit that referenced this issue May 13, 2019
+ Refactoring and minor improvements
+ ESLint
@suhrmann
Copy link
Owner

Should be fixed by commit 85825b6

Cigars now appear twice in the table: Once as basic demand for investors and second as luxury demand for obreros.

@exarkun1298 @xenonisbad In case you would rather see only one (summed up) entry for cigars in the table, please let me know.

@GrumpyCatastrophe
Copy link
Author

Consumption looks good now, thank You for quick fix. Separate occurrences for luxury and basic cigars are completely fine in consumption column, if anyone need it, adding those two values will be super easy, everybody can do it in their head. Good idea with pop-up message.

However there is a problem when it comes chains efficiency. We see that we need X% efficiency on x cigars chains and Y% efficiency on y cigar chains. X% and Y% cannot be easily added, and we have to choose efficiency for whole island, so separate values here meaningless. Unless of course we have separate cigar production chains on two islands. I don't use those values, but I guess many people would.

Conclusion: the best would be to somehow combine appearance of cigars in table when consumable are not filtered. I doubt it will be as easy fix though.

Btw. I just checked that there is missing cigar production for investors in "Production Chains".

@suhrmann suhrmann assigned tbfuerst and unassigned suhrmann May 13, 2019
@suhrmann suhrmann added enhancement New feature or request and removed bug Something is obviously not working labels May 18, 2019
@suhrmann
Copy link
Owner

Investor's cigars bug fixed.
Now still an enhancement

@suhrmann
Copy link
Owner

suhrmann commented Nov 8, 2020

-> Enhancement moved to #25

@suhrmann suhrmann closed this as completed Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants