Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile latest? #51

Closed
rotv opened this issue May 4, 2016 · 8 comments
Closed

Can't compile latest? #51

rotv opened this issue May 4, 2016 · 8 comments

Comments

@rotv
Copy link
Contributor

rotv commented May 4, 2016

Just me?

~/utils/433Utils/RPi_utils $ make
g++ -DRPI -c -o ../rc-switch/RCSwitch.o ../rc-switch/RCSwitch.cpp
../rc-switch/RCSwitch.cpp: In member function ‘void RCSwitch::send(long unsigned int, unsigned int)’:
../rc-switch/RCSwitch.cpp:493:26: error: ‘bitRead’ was not declared in this scope
: recipe for target '../rc-switch/RCSwitch.o' failed
make: *** [../rc-switch/RCSwitch.o] Error 1

@fingolfin
Copy link
Collaborator

bitRead is part of the Arduino libs. I only used it for extra readability, but will get rid of it.

@fingolfin
Copy link
Collaborator

I hope 1906097 resolves this

@rotv
Copy link
Contributor Author

rotv commented May 4, 2016

Now it compiles but I can't send or receive RF signals. Investigating.

@rotv
Copy link
Contributor Author

rotv commented May 4, 2016

I just verified that it works with my old fork, so something has taken the turn for the worse recently :(

@rotv
Copy link
Contributor Author

rotv commented May 4, 2016

It works all the way up to commit 90d00c1

@rotv
Copy link
Contributor Author

rotv commented May 4, 2016

It seems like the refactor of the send code af0c25a has broken it (I tried by checking out af0c25a and manually fixed according to 1906097).

@rotv
Copy link
Contributor Author

rotv commented May 4, 2016

Got it! The for-loop at RCSwitch.cpp:478 sends the bits in the wrong order, it should send MSB first.

@rotv
Copy link
Contributor Author

rotv commented May 4, 2016

Closing this issue (the compilation error is solved by 1906097). Opening a new one for the issue of incorrect bit order: #52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants