Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catching non-malicious manifest corruption #88

Closed
hannestschofenig opened this issue Jul 6, 2023 · 0 comments · Fixed by #112
Closed

Catching non-malicious manifest corruption #88

hannestschofenig opened this issue Jul 6, 2023 · 0 comments · Fixed by #112

Comments

@hannestschofenig
Copy link
Collaborator

** Section 6.2.1
When executing Common prior to authenticity validation, the Manifest
Processor MUST first evaluate the integrity of the manifest using the
SUIT_Digest present in the authentication block.

Is this action for security reasons or to catch non-malicious corruption? I ask because if this manifest was attacker-generated with a bogus signature (but unchecked), won't the digest value be under attacker control so it will always be match?
bremoran added a commit that referenced this issue Sep 13, 2023
@bremoran
Addresses 88: Digest verification to catch corruption
74066c6 
Fixes #88.
@bremoran bremoran mentioned this issue Sep 13, 2023
Merged
bremoran added a commit that referenced this issue Oct 23, 2023
@bremoran @hannestschofenig
Addresses 88: Digest verification to catch corruption (#112)
1366c6c 
* Addresses 88: Digest verification to catch corruption

Fixes #88.

* Update draft-ietf-suit-manifest.md

Co-authored-by: Hannes Tschofenig <hannes.tschofenig@gmx.net>

---------

Co-authored-by: Hannes Tschofenig <hannes.tschofenig@gmx.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addresses 88: Digest verification to catch corruption suit-wg/manifest-spec
1 participant
@hannestschofenig