Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding postcss-apply #44

Closed
giuseppeg opened this issue Sep 23, 2016 · 6 comments
Closed

Consider adding postcss-apply #44

giuseppeg opened this issue Sep 23, 2016 · 6 comments
Milestone

Comments

@giuseppeg
Copy link
Member

giuseppeg commented Sep 23, 2016

It can be handy and I personally like the syntax.

@tabatkins sorry to bother you, do you think that it is safe to consider this feature future-proof or are there chances that it'll be discarded?

Interesting thread tabatkins/specs#43

@tabatkins
Copy link

Nothing is safe until it ships in 2 browsers.

@giuseppeg
Copy link
Member Author

@tabatkins yeah that was my thought the other day.

@simonsmith maybe we should consider reverting this commit and let the users decide what to add?

People is scared as phuck to use not standard and w3c recommended features.

Even though one could argue that all this fear is a bit silly because postcss could be used as refactoring tool with codemod-like plugins, it is probably still a good idea to keep the plugins set to the bare minimum to avoid lots of bug reports and such.

@simonsmith
Copy link
Member

Couldn't the same logic be applied to the color-function and custom-media?

There is always quite a bit of FUD around postcss from Sass developers, so not sure that is a fair test but if you think it's risky adding apply then I'm happy to remove it.

@simonsmith
Copy link
Member

If we were to follow the 'ships in two browsers rule' (which sounds sensible) is there anything else from this list that falls into that category? If so we could add those too.

Would be good to follow a rule like that for plugin inclusion rather than ones that we personally use.

@giuseppeg
Copy link
Member Author

giuseppeg commented Sep 29, 2016

@simonsmith I guess that we can add all the features that are at a Candidate Recommendation stage if the plugins are [somehow] stable. So I guess that none of them qualifies.

Should we remove apply and color function?

@simonsmith
Copy link
Member

My feeling is keep them. I don't share the same fear that the postcss plugins will suddenly become abandoned. Has that happened somewhere else?

I think in the event of that we could convince the author to move them under the postcss org. With cssnext depending on them too there would be interest in keeping them going.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants