Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smile new doesn't show #22

Closed
EstebanC02 opened this issue Jul 9, 2017 · 1 comment
Closed

Smile new doesn't show #22

EstebanC02 opened this issue Jul 9, 2017 · 1 comment

Comments

@EstebanC02
Copy link

Hi guys! You are making such a great job, i really like your library. I am detect an issue when is select the New Smile, it doesn't show it. Also doesn't show when the smileRating.setSelectedSmile is loaded.

Android version: 5.1.1
Model number: SM-J120M
compile 'com.github.sujithkanna:smileyrating:1.6.7'

screenshot_2017-07-09-17-43-16-1-min

But when i select another Smile and come back with the New, in that case it is show it

screenshot_2017-07-09-17-43-02-1-min

screenshot_2017-07-09-17-43-05-1-min
addisonElliott added a commit to addisonElliott/SmileyRating that referenced this issue Jul 11, 2017
@addisonElliott
Fix issue sujithkanna#22
ee01c6a 
Bug in moveSmile function where the calculated fraction when selecting the last smiley would be barely above 1.0f. As an example, while debugging, the result was 1.000001f.

In the moveSmileByFraction function, if the fraction was not between 0.0f->1.0f, then it would return doing nothing. Thus, the solution is to clamp the fraction between 0.0f->1.0f and remove the if statement checking for a valid range.

This bug was only visible in certain instances because it depended on a number of variables whether the fraction was above 1.0f. This is why the bug was only present in certain builds, certain layouts, etc.
@addisonElliott addisonElliott mentioned this issue Jul 11, 2017
Closed
sujithkanna added a commit that referenced this issue Jul 12, 2017
@sujithkanna
Merge pull request #23 from addisonElliott/fix-great-smiley-invisible
45c8d71 
Fix issue #22
@sujithkanna sujithkanna mentioned this issue Jul 12, 2017
Merged
@sujithkanna
Copy link
Owner

Thank you for the fixTh @addisonElliott , Your fix worked very well. @EstebanC02 , use the updated version of the SmileyRating. Thank you!

@shining-cat shining-cat mentioned this issue May 24, 2018
Closed
zeidat pushed a commit to zeidat/SmileyRating that referenced this issue Sep 1, 2019
Merged PR 103: Merge feature/registration to develop
2a7da35 
1. Registration flow was added
2. Main color was changed and added to StyleKit
3. Material library was applied on registration textFields

Related work items: sujithkanna#22, sujithkanna#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sujithkanna @EstebanC02