Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting terrible first time results in normal color #24

Closed
addisonElliott opened this issue Jul 11, 2017 · 0 comments
Closed

Selecting terrible first time results in normal color #24

addisonElliott opened this issue Jul 11, 2017 · 0 comments

Comments

@addisonElliott
Copy link
Contributor

addisonElliott commented Jul 11, 2017 •
edited

Selecting the terrible smiley face the very first time results in the color of the terrible face to be the normal color instead of the angry face color setting.

My thought is that it has to do with an animation not taking place since it is the first time and the color is not set.

1
@addisonElliott addisonElliott changed the title Selecting Terrible First Time Results in Normal Color Selecting terrible first time results in normal color Jul 11, 2017
addisonElliott added a commit to addisonElliott/SmileyRating that referenced this issue Jul 11, 2017
@addisonElliott
Fix issue sujithkanna#24
c649a70 
Bug where clicking on terrible smiley the first time would result in it being colored normally instead of angry color.

When the previous selected state or new selected state of a smiley is NONE, then things are handled differently since there is no previous or next state to translate to. Instead, the background color is faded from deselected to selected. However, it was hardcoded to fade to normal color when there should be a check if the previous or next selected state and set to angry color if so.
@addisonElliott addisonElliott mentioned this issue Jul 11, 2017
Closed
sujithkanna added a commit that referenced this issue Jul 12, 2017
@sujithkanna
Merge pull request #25 from addisonElliott/fix-smiley-terrible-wrong-…
67546d9 
…color

Fix issue #24
@sujithkanna sujithkanna mentioned this issue Jul 12, 2017
Merged
zeidat pushed a commit to zeidat/SmileyRating that referenced this issue Sep 1, 2019
Merged PR 103: Merge feature/registration to develop
2a7da35 
1. Registration flow was added
2. Main color was changed and added to StyleKit
3. Material library was applied on registration textFields

Related work items: sujithkanna#22, sujithkanna#24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@addisonElliott