Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> master When to merge ? #871

Closed
antiDigest opened this issue Jun 24, 2021 · 5 comments
Closed

dev -> master When to merge ? #871

antiDigest opened this issue Jun 24, 2021 · 5 comments

Comments

@antiDigest
Copy link
Collaborator

Maybe we can discuss here when it would be appropriate to merge the dev branch to master.

I'm thinking:

  • we can stop any merges to master, make master the main branch (which it already is) and only allow new plugins to dev. Maybe even organize new additions. Like every new plugin requires a unit test or something to be able to merge. (Maybe more of a long term plan here, but I think you get my point.)
  • But in the current scenario, I would suggest pausing all merges to master, and making dev the open branch to merge into. Reason being, master is already too different from dev, I think. Until we figure out how to make those same, better to keep merging open only to dev.

Thoughts @pnhofmann. We can tag other collaborators for more thoughts as well.

@pnhofmann
Copy link
Collaborator

Yeah, merge dev is really overdue. Next month I should have some time (I'd like to do some improvements on voice control). Then I would suggest, merge in August?

Reason being, master is already too different from dev, I think.

Yes, I'll take care of the diffs - I don't think that's a major problem. I would suggest, handle master and if dev is ready to merge, I'll just "backport" everything on master ;).

@pnhofmann
Copy link
Collaborator

I'm late. But it's still August ;)

A preview what I did so far: https://github.com/pnhofmann/Jarvis/commits/dev

OK, now everything I decided I want to change is implemented. But I know: Lots of stuff is still a bit broken. So I'll do testing the next days. Guess, I'll need ~2 weeks and then I'll write again.

@pnhofmann pnhofmann pinned this issue Aug 31, 2021
@Milind220
Copy link
Contributor

What's going on with this? Was dev originally planned to be the branch that all PR's would be made to and master would have the stable release?

@pnhofmann
Copy link
Collaborator

Hi @Milind220
dev started with me experimenting stuff, but got lots of - I think - really interesting features. I consider it the next "release" of Jarvis.
And yes, it should really been merged by now. Sorry - I currently have unexpectedly lots of stuff "around". But sometime dev will be ready ;).

Maybe, if you do stuff like in #913 (any improvements really appreciated ;) ) - consider switching to dev ;).

@pnhofmann
Copy link
Collaborator

dev -> master When to merge ?

Soon

@pnhofmann pnhofmann unpinned this issue Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants