Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Spinwheel so that it has a spinwheel GUI instead of just showing output in terminal #1077

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

spacecowbye
Copy link
Contributor

@spacecowbye spacecowbye commented Apr 11, 2023

This was the output before
spinwheelbefore

I added a create spinwheel function which will display the output in a proper spinwheel image format
spinwheelafter

@pnhofmann
Copy link
Collaborator

Hey, year - works good. I do like it, my only concern is, it (obviously) doesn't work if you are working CLI-only without GUI.

I'll probably add a require(XSERVER) ore something. Comment here, should I forget ;).

Additionally, a close function is required, otherwise the window will stay open forever + block further Jarvis operations
https://stackoverflow.com/questions/8009176/function-to-close-the-window-in-tkinter

@spacecowbye
Copy link
Contributor Author

yeah sure thanks!! I dont know what to do if I am are working CLI-only without GUI, I can add the close function right now!!

@spacecowbye
Copy link
Contributor Author

Added the line to destroy the window after 3 seconds!!

@spacecowbye
Copy link
Contributor Author

Hey, year - works good. I do like it, my only concern is, it (obviously) doesn't work if you are working CLI-only without GUI.

I'll probably add a require(XSERVER) ore something. Comment here, should I forget ;).

Additionally, a close function is required, otherwise the window will stay open forever + block further Jarvis operations https://stackoverflow.com/questions/8009176/function-to-close-the-window-in-tkinter

hello can you please close the issue and merge the pr

@pnhofmann pnhofmann merged commit 369a0e0 into sukeesh:master Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants