Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ask user for column input again in connect_four instead of throwing error #1129

Closed
nagxsan opened this issue Aug 26, 2023 · 2 comments · Fixed by #1130
Closed

fix: Ask user for column input again in connect_four instead of throwing error #1129

nagxsan opened this issue Aug 26, 2023 · 2 comments · Fixed by #1130

Comments

@nagxsan
Copy link
Contributor

nagxsan commented Aug 26, 2023 •
edited
Loading

Description

In the connect_four plug-in, if the user enters a non-numeric value as input for column, then an error is thrown to the user which interrupts the gameplay and stops it. Instead of throwing ValueError to the user, we can simply ask them again for the column input till they enter a numeric input.

Before

Screenshot 2023-08-26 200414
@nagxsan nagxsan mentioned this issue Aug 26, 2023
Merged
@nagxsan
Copy link
Contributor Author

nagxsan commented Aug 26, 2023

Here is the PR for the fix as stated above

@nagxsan
Copy link
Contributor Author

nagxsan commented Aug 27, 2023

@pnhofmann is this fine or should I change something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ask user again for valid column input in connect_four instead of throwing error nagxsan/Jarvis
1 participant
@nagxsan