Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment of ribbons #94

Closed
curran opened this issue Dec 7, 2016 · 3 comments
Closed

Fix alignment of ribbons #94

curran opened this issue Dec 7, 2016 · 3 comments
Assignees
@curran

Comments

@curran
Copy link
Collaborator

curran commented Dec 7, 2016

The centers of the ribbons don't quite line up with the centers of the notes:

image

Probably this would be a quick fix on the conversion of Y scale from band to linear.
@curran curran closed this as completed Mar 14, 2017
@curran
Copy link
Collaborator Author

curran commented Mar 15, 2017

I believe the problem is still there, and it lies in the ribbons not the notes.

@curran curran reopened this Mar 15, 2017
@curran
Copy link
Collaborator Author

curran commented Mar 16, 2017

Potentially related to https://github.com/sul-cidr/josquin-ribbon/blob/gh-pages/js/dev/notesbook.js#L32

@curran curran self-assigned this Mar 16, 2017
@curran curran mentioned this issue Mar 16, 2017
Merged
@curran
Copy link
Collaborator Author

curran commented Mar 22, 2017 •
edited
Loading

After fix:

image

for ?id=Jos1913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curran curran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@curran