adds mailer and feedback form functionality #130
Conversation
| if request.post? | ||
| if validate | ||
| RecordMailer.submit_feedback(params, request.remote_ip) | ||
| flash[:success] = t('blacklight.feedback_form.success').html_safe |
There was a problem hiding this comment.
Ok so html_safe here does not appear to be helping with rendering tags correctly
There was a problem hiding this comment.
We should remove this since we're now calling #html_safe in the overridden partial.
|
Coverage decreased (-0.23%) when pulling 425a40be6f2fe257bb8027785670bf1e0feff53e on feedback into 9bd2efa on master. |
|
Coverage increased (+0.21%) when pulling ce4a2b299fe867098eca9cb4ae6fc24dae34bc46 on feedback into 094013e on master. |
| else | ||
| false | ||
| end | ||
| end |
There was a problem hiding this comment.
This can probably be written a little more concisely as:
def show_feedback_form?
!controller.instance_of?(FeedbackFormsController)
end
There was a problem hiding this comment.
Also, a simple helper test may be in order (just in case this logic ever grows in complexity).
|
What's w/ the empty Under which condition do we get there (and should we try to prevent that)? |
|
@jkeck we don't anymore it seems... removing |
| class RecordMailer < ActionMailer::Base | ||
|
|
||
| def submit_feedback(params, ip) | ||
| if !params[:name].blank? |
There was a problem hiding this comment.
I think params[:name].present? may read a little better. (as well as params[:to].present? below)
That may just be my personal style, so I leave that 💯 % up to your discretion.
adds mailer and feedback form functionality
Fixes #37
Adds feedback form functionality to application with test suites. I am scoping out the quick book report button to another ticket as it may depend on #78
One issue is that the html rendering of the flash is not rendering html tags correctly. Any suggestions?
html_safedoes not seem to work.