tracks external link clicks using Google Analytics #2135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejackreed
force-pushed
the
outbound-linkz
branch
from
288a89b
to
54e27b5
Compare
mejackreed
force-pushed
the
outbound-linkz
branch
from
54e27b5
to
ae82332
Compare
mejackreed
force-pushed
the
outbound-linkz
branch
from
ae82332
to
6cb37db
Compare
mejackreed
commented
Nov 9, 2018
| }); | ||
|
|
||
| // Track external link clicks | ||
| $('a[href]:not([href^="/"],[href^="#"])').on('click', function(e) { |
There was a problem hiding this comment.
I think this should be the correct selector. I'm not sure if there are any other considerations we should make here?
There was a problem hiding this comment.
This will end up tracking any time we use a fully qualified URL? I don't think we use that a lot, but just want to make sure I know the considerations we may have to take moving forward.
jkeck
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2114
The URL will be reported which i think is sufficient to accomplish: