-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDR display - Record view - Update Context Panels #2178
SDR display - Record view - Update Context Panels #2178
Conversation
52d12fe
to
9145638
Compare
68ce1dd
to
a652d59
Compare
Combine panel body and footer
9e0d11d
to
803f32c
Compare
@@ -2,6 +2,9 @@ | |||
<%= render "catalog/access_panels/online" %> | |||
<%= render "catalog/access_panels/course_reserve" %> | |||
<%= render "catalog/access_panels/location" %> | |||
<% if (@document.set_member? && @document.parent_sets.present?) || (@document.is_a_collection_member? && @document.parent_collections.present?) %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this to try and only render context if appears_in
or in_collection
has content? If so, perhaps we can render both of those into a variable and check that one of them has content. This way, if the logic w/i one of those partials changes, we don't have to remember to update the logic in this partial to match.
👍 Thanks for showing me this neat pattern, @jkeck
|
Closes #2108
Before
After