Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDR display - Record view - Update Context Panels #2178

Merged
merged 2 commits into from
Nov 19, 2018

Conversation

camillevilla
Copy link
Contributor

@camillevilla camillevilla commented Nov 15, 2018

Closes #2108

Before

screen shot 2018-11-16 at 2 47 58 pm
screen shot 2018-11-16 at 2 48 04 pm

After

screen shot 2018-11-16 at 2 46 27 pm
screen shot 2018-11-16 at 2 46 23 pm

@coveralls
Copy link

coveralls commented Nov 15, 2018

Coverage Status

Coverage remained the same at 96.821% when pulling 02e1172 on 2108-sdr-record-context-panels into 1c1ca3d on 🎨-sdr-item-record-redesign.

@camillevilla camillevilla force-pushed the 2108-sdr-record-context-panels branch 4 times, most recently from 52d12fe to 9145638 Compare November 16, 2018 23:07
@aeschylus aeschylus force-pushed the 2108-sdr-record-context-panels branch from 68ce1dd to a652d59 Compare November 16, 2018 23:44
Combine panel body and footer
@aeschylus aeschylus force-pushed the 2108-sdr-record-context-panels branch from 9e0d11d to 803f32c Compare November 17, 2018 00:22
@camillevilla camillevilla changed the title [WIP] SDR display - Record view - Update Context Panels SDR display - Record view - Update Context Panels Nov 17, 2018
@@ -2,6 +2,9 @@
<%= render "catalog/access_panels/online" %>
<%= render "catalog/access_panels/course_reserve" %>
<%= render "catalog/access_panels/location" %>
<% if (@document.set_member? && @document.parent_sets.present?) || (@document.is_a_collection_member? && @document.parent_collections.present?) %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to try and only render context if appears_in or in_collection has content? If so, perhaps we can render both of those into a variable and check that one of them has content. This way, if the logic w/i one of those partials changes, we don't have to remember to update the logic in this partial to match.

@camillevilla
Copy link
Contributor Author

👍 Thanks for showing me this neat pattern, @jkeck

<%
document ||= @document
contributors = render(partial: "catalog/record/marc_contributors", locals: {document: document})
contents_summary = render(partial: "catalog/record/marc_contents_summary", locals: {document: document})
subjects = render(partial: "catalog/record/marc_subjects", locals: {document: document})
bibliography = render(partial: "catalog/record/marc_bibliographic", locals: {document: document})

@jkeck jkeck merged commit f57a8ef into 🎨-sdr-item-record-redesign Nov 19, 2018
@jkeck jkeck deleted the 2108-sdr-record-context-panels branch November 19, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants