Update dependencies #844
Merged
Update dependencies #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
update-dependencies
branch
3 times, most recently
from
04f3afd
to
5743c6d
Compare
cbeer
force-pushed
the
update-dependencies
branch
from
5743c6d
to
f54657f
Compare
houndci-bot
reviewed
Oct 19, 2016
| end | ||
| end | ||
| result.instance_eval do | ||
| def save ; true ; end |
houndci-bot
reviewed
Oct 19, 2016
| # end | ||
| # end | ||
| ds.instance_eval do | ||
| def save ; true ; end |
houndci-bot
reviewed
Oct 19, 2016
| end | ||
| end | ||
|
|
||
| # stub item and datastream repo access methods | ||
| result.datastreams.each_pair do |dsid, ds| |
There was a problem hiding this comment.
Unused block argument - dsid. If it's necessary, use _ or _dsid as an argument name to indicate that it won't be used.
cbeer
force-pushed
the
update-dependencies
branch
from
f54657f
to
f406723
Compare
jmartin-sul
reviewed
Oct 25, 2016
| @@ -8,7 +8,7 @@ | |||
| @item = instantiate_fixture(@druid, Dor::Item) | |||
| @user = User.find_or_create_by_webauth double('WebAuth', :login => 'sunetid', :logged_in? => true, :attributes => {'DISPLAYNAME' => 'Example User'}, :privgroup => '') | |||
| allow(Dor).to receive(:find).with("druid:#{@druid}").and_return(@item) | |||
| allow(Dor::Item).to receive(:find).with("druid:#{@druid}").and_return(@item) | |||
| allow(Dor).to receive(:find).with("druid:#{@druid}").and_return(@item) | |||
There was a problem hiding this comment.
since it's an allow, and the two lines are now identical, could we just remove this?
| @@ -39,6 +39,7 @@ end | |||
|
|
|||
| if ['test', 'development'].include? Rails.env | |||
| require 'jettywrapper' | |||
| Jettywrapper.hydra_jetty_version = 'v7.3.0' | |||
There was a problem hiding this comment.
could you add a comment explaining the version specification?
Update dependencies jm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argo also needed changes to fixture object loading; whereas in AF 6.0, the
ActiveFedora::Baseclass provided access to all datastreams, in later versions these needed to be made explicit. The easy thing to do was to simply cast objects to their expected classes.