use leaflet methods rather than our own #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejackreed
force-pushed
the
use-leaflet-methods-instead
branch
from
80ff196
to
9195e45
Compare
cbeer
added a commit
to sul-dlss/exhibits
that referenced
this pull request
Feb 10, 2017
cbeer
added a commit
to sul-dlss/exhibits
that referenced
this pull request
Feb 10, 2017
jkeck
pushed a commit
to sul-dlss/exhibits
that referenced
this pull request
Feb 10, 2017
Solves the temporary leaflet/rails asset icon path fiasco of 2016 / 2017
mejackreed
force-pushed
the
use-leaflet-methods-instead
branch
from
cd10f79
to
6b7d137
Compare
cbeer
reviewed
Feb 13, 2017
| @@ -334,7 +334,9 @@ L.SolrHeatmap = L.GeoJSON.extend({ | |||
| } | |||
|
|
|||
| var bounds = this._map.getBounds(); | |||
| return [bounds.getWest(), bounds.getSouth(), bounds.getEast(), bounds.getNorth()].join(','); | |||
| var wrappedSw = bounds.getSouthWest().wrap(); | |||
There was a problem hiding this comment.
Is this file the same as https://github.com/mejackreed/leaflet-solr-heatmap/blob/master/leafletSolrHeatmap.js (and imply that upstream should get updated too/first)?
There was a problem hiding this comment.
No. that was a first pass, and hasn't been updated yet. It has diverged a bit, but tech debt would to bring upstream inline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.