Update rspec and rails #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejackreed
reviewed
Feb 24, 2017
config/cable.yml
Outdated
| @@ -0,0 +1,9 @@ | |||
| development: | |||
There was a problem hiding this comment.
Do we need to include this if we aren't using action cable?
There was a problem hiding this comment.
Hmm, that's a good question. It gets automatically scaffolded in all new rails apps, and I have seen it sitting around vestigially in some non-ActionCable implementing rails 5 apps. That being said, I'll kill it and see if things are still happy. We can easily re-create it if we ever decided to implement ActionCable 
.
jkeck
force-pushed
the
update-rspec-and-rails
branch
from
549e7f9
to
f48a340
Compare
jkeck
force-pushed
the
update-rspec-and-rails
branch
from
f48a340
to
4a25f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work on #40