Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when sdrPreserve is missing (or admin is missing) for a file, assume TRUE #610

Closed
ndushay opened this issue Mar 10, 2020 · 1 comment
Closed
Assignees

Comments

@ndushay
Copy link
Contributor

ndushay commented Mar 10, 2020

PR #609 makes it so we only generate tech md for Files when they explicitly have sdrPreserve set to true.

Not sure if changing the default in cocina models (issue sul-dlss/cocina-models#87) will be sufficient to ensure that this service will always generate techmd; it depends if this service always receives fully fleshed out file objects, or can get the abbreviated ones as in the tests added in PR #609.

If this service can get abbreviated File model objects (without default explicit) then the behavior here will need to change.

@ndushay
Copy link
Contributor Author

ndushay commented Mar 11, 2020

#609 dealth with this.

@ndushay ndushay closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant