add parsing of previous catkeys to purl xml model; add tests that were pending #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
changed the title
drh-stanford
approved these changes
Mar 2, 2017
| @@ -209,6 +210,11 @@ def parse_catkey | |||
| get_value(@purlxml_ng_doc.xpath("/publicObject/identityMetadata/otherId[@name='catkey']")) | |||
| end | |||
|
|
|||
| # @return previous catkey values from the DOR identity_metadata as an array, or empty array if there are no previous catkeys | |||
| def parse_previous_catkeys | |||
| @purlxml_ng_doc.xpath("/publicObject/identityMetadata/otherId[@name='previous_catkey']").map { |node| node.content } | |||
There was a problem hiding this comment.
minor nit: style-wise i think this should be collect, not map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will be used in https://github.com/sul-dlss/sw-indexer to call the 856 record service for when previous catkeys are present in the record