Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Dump poorly named and unnecessary hash arg when opening versions
Includes: * Move version open params nested in hash up a level so they are top-level params * Avoid coercing significance value to a symbol in `VersionsController`; this is already coerced in `VersionService`, and brings symmetry to `#open_params` and `#close_params` * Prefer `#symbolize_keys` to `#deep_symbolize_keys` when not working with a nested hash structure * Update YARD documentation in `VersionService` now that the open params have been promoted to top-level * Prefer `#save!` to `#save` for ActiveFedora objects (do not hide errors)
- Loading branch information
Showing
4 changed files
with
33 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters