alert honeybadger for incomplete response from Symphony

sul-dlss · Sep 6, 2019 · a12c41d · a12c41d
1 parent 070e438
commit a12c41d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/app/models/symphony_reader.rb b/app/models/symphony_reader.rb
@@ -50,6 +50,7 @@ def validate_response(resp)
     return resp if actual_content_length == exp_content_length
 
     errmsg = "Incomplete response received from Symphony for #{@catkey} - expected #{exp_content_length} bytes but got #{actual_content_length}"
+    Honeybadger.notify(errmsg)
     raise RecordIncompleteError, errmsg
   end
 

diff --git a/spec/models/symphony_reader_spec.rb b/spec/models/symphony_reader_spec.rb
@@ -63,8 +63,12 @@
 
     context 'when wrong number of bytes received from Symphony' do
       let(:headers) { { 'Content-Length': 268 } }
-      it 'raises RecordIncompleteError' do
-        expect { reader.to_marc }.to raise_error(SymphonyReader::RecordIncompleteError, 'Incomplete response received from Symphony for catkey - expected 268 bytes but got 394')
+
+      it 'raises RecordIncompleteError and notifies Honeybadger' do
+        msg = 'Incomplete response received from Symphony for catkey - expected 268 bytes but got 394'
+        allow(Honeybadger).to receive(:notify)
+        expect { reader.to_marc }.to raise_error(SymphonyReader::RecordIncompleteError, msg)
+        expect(Honeybadger).to have_received(:notify).with(msg)
       end
     end
   end