Return HTTP 400 with an informative message when metadata to be published #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinlittman
approved these changes
Aug 22, 2019
|
I was thinking more broadly, as, as stated in the ticket (which this PR closed, ahem), I believe we can possibly change a rails setting and get more info from the specific error. Should I re-open the ticket? |
|
And, by the way, it was a 500 error for the publish step, so not sure this even fixes that. |
|
@ndushay It does fix the 500 error, which was caused by a lack of more specific exception handling in the app. |
ndushay
reviewed
Aug 22, 2019
| @@ -11,6 +11,10 @@ class ObjectsController < ApplicationController | |||
| render status: 409, plain: e.message, location: object_location(e.pid) | |||
| end | |||
|
|
|||
| rescue_from(DublinCoreService::CrosswalkError) do |e| | |||
| render status: 400, plain: e.message | |||
There was a problem hiding this comment.
400 is misleading -- there is nothing wrong with the REQUEST -- it is the dor object empty descMetadata that is the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331
@ndushay This is a very specific fix to #331. I'm not sure if you were hoping for a more general (across-the-board) fix. I'm probably inclined to fix the narrowest case and add more error handling as we find other exceptions that don't bubble up useful information, but I am open to pushback on this if you think it's too short-sighted.