Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goobi integration #35

Merged
merged 13 commits into from
Nov 8, 2016
Merged

Goobi integration #35

merged 13 commits into from
Nov 8, 2016

Conversation

peetucket
Copy link
Member

Add new web service endpoint to make calls to Goobi Digitization Service to indicate when an object is registered. see https://docs.google.com/document/d/127Qbx9LFL6Ver9qWj5M_ZmRBERW9s1umpMVR38pwvMI and https://github.com/sul-dlss/sul-goobi/issues/7

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9136314 on goobi-integration into * on master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9136314 on goobi-integration into * on master*.

@coveralls
Copy link

coveralls commented Nov 2, 2016

Coverage Status

Changes Unknown when pulling a00b417 on goobi-integration into * on master*.

@coveralls
Copy link

coveralls commented Nov 2, 2016

Coverage Status

Changes Unknown when pulling 8b8b4c4 on goobi-integration into * on master*.

@coveralls
Copy link

coveralls commented Nov 2, 2016

Coverage Status

Changes Unknown when pulling ebac31c on goobi-integration into * on master*.

@coveralls
Copy link

coveralls commented Nov 2, 2016

Coverage Status

Changes Unknown when pulling c9c756f on goobi-integration into * on master*.

@coveralls
Copy link

coveralls commented Nov 2, 2016

Coverage Status

Changes Unknown when pulling 4e7b13b on goobi-integration into * on master*.

@coveralls
Copy link

coveralls commented Nov 4, 2016

Coverage Status

Changes Unknown when pulling eef5bf5 on goobi-integration into * on master*.

@coveralls
Copy link

coveralls commented Nov 7, 2016

Coverage Status

Changes Unknown when pulling 3d696c5 on goobi-integration into * on master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d9610d3 on goobi-integration into * on master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d9610d3 on goobi-integration into * on master*.

…r-services-app to respond correctly to robots
@coveralls
Copy link

coveralls commented Nov 8, 2016

Coverage Status

Changes Unknown when pulling 474e469 on goobi-integration into * on master*.

@peetucket peetucket changed the title [WIP] Goobi integration Goobi integration Nov 8, 2016
@@ -222,6 +222,16 @@ def app
end
end

describe '/publish' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious this didn't have a test as it's probably the most used route we have :)

Copy link

@drh-stanford drh-stanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good. My only substantive comment would be to externalize the fixture data in spec_helper.

@peetucket
Copy link
Member Author

Thanks, just took the simplistic approach of moving all of those methods for fixture data into their own file and requiring it separately to keep the spec_helper itself more clean.

@coveralls
Copy link

coveralls commented Nov 8, 2016

Coverage Status

Changes Unknown when pulling 2569931 on goobi-integration into * on master*.

@drh-stanford drh-stanford merged commit 7a560e6 into master Nov 8, 2016
@drh-stanford drh-stanford deleted the goobi-integration branch November 8, 2016 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants