Rescue versioning exceptions and provide more context #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
approved these changes
Sep 11, 2019
| @@ -12,7 +12,7 @@ def create | |||
| parent_id, child_ids = virtual_object.values_at(:parent_id, :child_ids) | |||
| # Update the constituent relationship between the parent and child druids | |||
| errors << ConstituentService.new(parent_druid: parent_id).add(child_druids: child_ids) | |||
| rescue ActiveFedora::ObjectNotFoundError, Rubydora::FedoraInvalidRequest => e | |||
| rescue ActiveFedora::ObjectNotFoundError, Rubydora::FedoraInvalidRequest, Dor::Exception => e | |||
| raise Dor::Exception, 'accessionWF already created for versioned object' if accessioning? | ||
| raise Dor::Exception, "latest version in versionMetadata for #{work.pid} requires tag and description before it can be closed" unless work.versionMetadata.current_version_closeable? | ||
| raise Dor::Exception, "Trying to close version on #{work.pid} which is not opened for versioning" unless open_for_versioning? | ||
| raise Dor::Exception, "accessionWF already created for versioned object #{work.pid}" if accessioning? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why was this change made?
To provide more information to downstream consumers why operations fail and for which objects.
Was the API documentation (openapi.json) updated?
No, and it didn't need to be.